Scripting: Added Geometry interface with line and ellipse helpers #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing access from scripts to the existing line and ellipse rendering functions.
|
In the comments for ellipseRegion, it would be a good idea to specify whether the parameters represent a bounding rect, or the origin and radius. |
|
When using This doesn't affect the version that takes numbers, since that takes inclusive points for the rect, and thus cannot make a rectangle with width or height 0. |
Now the rectangle is normalized, and when it is empty, the returned region is also empty.
Since it is about how to handle the QRect when its size is negative, which is not specific to the scripting API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing access from scripts to the existing line and ellipse rendering functions.